prefer no dnstools solutions

web/whatismyip

@@ -13,14 +13,26 @@ function locals_only() {
   exit $?
 }
 function ifconfig_service() {
-  which curl &>/dev/null && {
+  which jq &>/dev/null && JQ="jq ." || JQ="cat -"
-    curl -4 ifconfig.co/json; exit $?
+  $CURL ifconfig.co/json | $JQ
-  }
+  exit $?
-  which wget &>/dev/null && {
-    wget -q -O - ifconfig.co/json; exit $?
-  }
 }
 
+function setup_curl() {
+  which curl &>/dev/null && {
+    CURL="curl -s -4"
+    return
+  }
+
+  which wget &>/dev/null && {
+    CURL="wget -q -O - "
+    return
+  }
+  echo "No curl or wget present" >2
+  exit 1
+}
+
+
 for (( i=1; i<=$#; i++ )); do
   [[ "${!i}" = "--help" ]] && helpexit
   [[ "${!i}" = "-h" ]] && helpexit
@@ -31,6 +43,8 @@ for (( i=1; i<=1; i++ )); do
   [[ "${!i}" = "-j" ]] && { JSON=1; continue; }
 done
 
+setup_curl
+
 if [[ "$LOCAL" -eq 1 ]]; then
   locals_only
 fi
@@ -39,15 +53,13 @@ if [[ "$JSON" -eq 1 ]]; then
   ifconfig_service
 fi
 
-which dig &> /dev/null || {
+IP=$( $CURL ifconfig.co/ip )
+if [[ -z "$IP" ]]; then
+  which dig &> /dev/null || {
     echo Install apt dnsutils >&2
     exit 1
-} 
+  }
-   
+  IP=$( dig +short myip.opendns.com @resolver1.opendns.com )
-
-IP=$( dig +short myip.opendns.com @resolver1.opendns.com )
-if [[ -z "$IP" ]]; then
-    IP=$( curl -s -4 ifconfig.co/ip )
 fi
 
 if [[ "$NAME" -eq 1 ]]; then